Skip to content

Commit

Permalink
net: aquantia: create global service workqueue
Browse files Browse the repository at this point in the history
We need this to schedule link interrupt handling and
various service tasks.

Signed-off-by: Nikita Danilov <ndanilov@aquantia.com>
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nikita Danilov authored and David S. Miller committed May 1, 2019
1 parent 1d2a8a1 commit 5860808
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 1 deletion.
41 changes: 41 additions & 0 deletions drivers/net/ethernet/aquantia/atlantic/aq_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,17 @@ MODULE_VERSION(AQ_CFG_DRV_VERSION);
MODULE_AUTHOR(AQ_CFG_DRV_AUTHOR);
MODULE_DESCRIPTION(AQ_CFG_DRV_DESC);

const char aq_ndev_driver_name[] = AQ_CFG_DRV_NAME;

static const struct net_device_ops aq_ndev_ops;

static struct workqueue_struct *aq_ndev_wq;

void aq_ndev_schedule_work(struct work_struct *work)
{
queue_work(aq_ndev_wq, work);
}

struct net_device *aq_ndev_alloc(void)
{
struct net_device *ndev = NULL;
Expand Down Expand Up @@ -209,3 +218,35 @@ static const struct net_device_ops aq_ndev_ops = {
.ndo_vlan_rx_add_vid = aq_ndo_vlan_rx_add_vid,
.ndo_vlan_rx_kill_vid = aq_ndo_vlan_rx_kill_vid,
};

static int __init aq_ndev_init_module(void)
{
int ret;

aq_ndev_wq = create_singlethread_workqueue(aq_ndev_driver_name);
if (!aq_ndev_wq) {
pr_err("Failed to create workqueue\n");
return -ENOMEM;
}

ret = aq_pci_func_register_driver();
if (ret) {
destroy_workqueue(aq_ndev_wq);
return ret;
}

return 0;
}

static void __exit aq_ndev_exit_module(void)
{
aq_pci_func_unregister_driver();

if (aq_ndev_wq) {
destroy_workqueue(aq_ndev_wq);
aq_ndev_wq = NULL;
}
}

module_init(aq_ndev_init_module);
module_exit(aq_ndev_exit_module);
2 changes: 2 additions & 0 deletions drivers/net/ethernet/aquantia/atlantic/aq_main.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
#define AQ_MAIN_H

#include "aq_common.h"
#include "aq_nic.h"

void aq_ndev_schedule_work(struct work_struct *work);
struct net_device *aq_ndev_alloc(void);

#endif /* AQ_MAIN_H */
11 changes: 10 additions & 1 deletion drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
Original file line number Diff line number Diff line change
Expand Up @@ -368,4 +368,13 @@ static struct pci_driver aq_pci_ops = {
.shutdown = aq_pci_shutdown,
};

module_pci_driver(aq_pci_ops);
int aq_pci_func_register_driver(void)
{
return pci_register_driver(&aq_pci_ops);
}

void aq_pci_func_unregister_driver(void)
{
pci_unregister_driver(&aq_pci_ops);
}

3 changes: 3 additions & 0 deletions drivers/net/ethernet/aquantia/atlantic/aq_pci_func.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,7 @@ int aq_pci_func_alloc_irq(struct aq_nic_s *self, unsigned int i,
void aq_pci_func_free_irqs(struct aq_nic_s *self);
unsigned int aq_pci_func_get_irq_type(struct aq_nic_s *self);

int aq_pci_func_register_driver(void);
void aq_pci_func_unregister_driver(void);

#endif /* AQ_PCI_FUNC_H */

0 comments on commit 5860808

Please sign in to comment.