Skip to content

Commit

Permalink
nilfs2: delete mark_inode_dirty in nilfs_commit_chunk
Browse files Browse the repository at this point in the history
Delete mark_inode_dirty() in nilfs_commit_chunk(), for callers of
nilfs_commit_chunk() will call equivalent mark_inode_dirty()
after calling nilfs_commit_chunk().

Signed-off-by: Jiro SEKIBA <jir@unicus.jp>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
  • Loading branch information
Jiro SEKIBA authored and Ryusuke Konishi committed Nov 27, 2009
1 parent 2093abf commit 58d5547
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions fs/nilfs2/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,8 @@ static void nilfs_commit_chunk(struct page *page,

nr_dirty = nilfs_page_count_clean_buffers(page, from, to);
copied = block_write_end(NULL, mapping, pos, len, len, page, NULL);
if (pos + copied > dir->i_size) {
if (pos + copied > dir->i_size)
i_size_write(dir, pos + copied);
mark_inode_dirty(dir);
}
if (IS_DIRSYNC(dir))
nilfs_set_transaction_flag(NILFS_TI_SYNC);
err = nilfs_set_file_dirty(sbi, dir, nr_dirty);
Expand Down
2 changes: 1 addition & 1 deletion fs/nilfs2/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ static int nilfs_mkdir(struct inode *dir, struct dentry *dentry, int mode)
inode->i_mapping->a_ops = &nilfs_aops;

inc_nlink(inode);
mark_inode_dirty(inode);

err = nilfs_make_empty(inode, dir);
if (err)
Expand All @@ -268,6 +267,7 @@ static int nilfs_mkdir(struct inode *dir, struct dentry *dentry, int mode)
if (err)
goto out_fail;

mark_inode_dirty(inode);
d_instantiate(dentry, inode);
out:
if (!err)
Expand Down

0 comments on commit 58d5547

Please sign in to comment.