Skip to content

Commit

Permalink
f2fs: replace test_and_set/clear_bit() with set/clear_bit()
Browse files Browse the repository at this point in the history
Since set/clear_inode_flag() don't need to return value to show
if flag is set, we can just call set/clear_bit() here.

Signed-off-by: Yufen Yu <yuyufen@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
  • Loading branch information
Yufen Yu authored and Jaegeuk Kim committed Aug 4, 2020
1 parent 567c4bf commit 58f7e00
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/f2fs/f2fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -2656,7 +2656,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode,

static inline void set_inode_flag(struct inode *inode, int flag)
{
test_and_set_bit(flag, F2FS_I(inode)->flags);
set_bit(flag, F2FS_I(inode)->flags);
__mark_inode_dirty_flag(inode, flag, true);
}

Expand All @@ -2667,7 +2667,7 @@ static inline int is_inode_flag_set(struct inode *inode, int flag)

static inline void clear_inode_flag(struct inode *inode, int flag)
{
test_and_clear_bit(flag, F2FS_I(inode)->flags);
clear_bit(flag, F2FS_I(inode)->flags);
__mark_inode_dirty_flag(inode, flag, false);
}

Expand Down

0 comments on commit 58f7e00

Please sign in to comment.