Skip to content

Commit

Permalink
media: imx: imx8mq-mipi-csi2: remove wrong irq config write operation
Browse files Browse the repository at this point in the history
The place where this register writel() that masks one interrupt is placed
does not guarantee that the device is powered so that's not allowed.
Moreover imx8mq_mipi_csi_start_stream() masks the interrupt anyway so the
write is not even needed. Remove it as this is a mistake that slipped in
with the driver.

Fixes: f33fd8d ("media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller")
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
  • Loading branch information
Martin Kepplinger authored and Mauro Carvalho Chehab committed Jan 23, 2022
1 parent e25a89f commit 59c2b6d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/staging/media/imx/imx8mq-mipi-csi2.c
Original file line number Diff line number Diff line change
Expand Up @@ -398,9 +398,6 @@ static int imx8mq_mipi_csi_s_stream(struct v4l2_subdev *sd, int enable)
struct csi_state *state = mipi_sd_to_csi2_state(sd);
int ret = 0;

imx8mq_mipi_csi_write(state, CSI2RX_IRQ_MASK,
CSI2RX_IRQ_MASK_ULPS_STATUS_CHANGE);

if (enable) {
ret = pm_runtime_resume_and_get(state->dev);
if (ret < 0)
Expand Down

0 comments on commit 59c2b6d

Please sign in to comment.