Skip to content

Commit

Permalink
Merge tag 'stable/for-linus-3.16-rc5-tag' of git://git.kernel.org/pub…
Browse files Browse the repository at this point in the history
…/scm/linux/kernel/git/xen/tip

Pull Xen fixes from Konrad Rzeszutek Wilk:
 "Two fixes found during migration of PV guests.  David would be the one
  doing this pull but he is on vacation.

  Fixes:
   - fix console deadlock when resuming PV guests
   - fix regression hit when ballooning and resuming PV guests"

* tag 'stable/for-linus-3.16-rc5-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
  xen/balloon: set ballooned out pages as invalid in p2m
  xen/manage: fix potential deadlock when resuming the console
  • Loading branch information
Linus Torvalds committed Jul 17, 2014
2 parents 22d3685 + fb9a0c4 commit 59ca9ee
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
12 changes: 5 additions & 7 deletions drivers/xen/balloon.c
Original file line number Diff line number Diff line change
Expand Up @@ -426,20 +426,18 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
* p2m are consistent.
*/
if (!xen_feature(XENFEAT_auto_translated_physmap)) {
unsigned long p;
struct page *scratch_page = get_balloon_scratch_page();

if (!PageHighMem(page)) {
struct page *scratch_page = get_balloon_scratch_page();

ret = HYPERVISOR_update_va_mapping(
(unsigned long)__va(pfn << PAGE_SHIFT),
pfn_pte(page_to_pfn(scratch_page),
PAGE_KERNEL_RO), 0);
BUG_ON(ret);
}
p = page_to_pfn(scratch_page);
__set_phys_to_machine(pfn, pfn_to_mfn(p));

put_balloon_scratch_page();
put_balloon_scratch_page();
}
__set_phys_to_machine(pfn, INVALID_P2M_ENTRY);
}
#endif

Expand Down
5 changes: 4 additions & 1 deletion drivers/xen/manage.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ static int xen_suspend(void *data)

if (!si->cancelled) {
xen_irq_resume();
xen_console_resume();
xen_timer_resume();
}

Expand Down Expand Up @@ -135,6 +134,10 @@ static void do_suspend(void)

err = stop_machine(xen_suspend, &si, cpumask_of(0));

/* Resume console as early as possible. */
if (!si.cancelled)
xen_console_resume();

raw_notifier_call_chain(&xen_resume_notifier, 0, NULL);

dpm_resume_start(si.cancelled ? PMSG_THAW : PMSG_RESTORE);
Expand Down

0 comments on commit 59ca9ee

Please sign in to comment.