Skip to content

Commit

Permalink
net: mvneta: fix locking in mvneta_cpu_online()
Browse files Browse the repository at this point in the history
When port is stopped, unlock before returning

Fixes: 413f027 ("net: protect NAPI enablement with netdev_lock()")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250121005002.3938236-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Harshit Mogalapalli authored and Jakub Kicinski committed Jan 23, 2025
1 parent 61dc1fd commit 59e00e8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/marvell/mvneta.c
Original file line number Diff line number Diff line change
Expand Up @@ -4432,6 +4432,7 @@ static int mvneta_cpu_online(unsigned int cpu, struct hlist_node *node)
*/
if (pp->is_stopped) {
spin_unlock(&pp->lock);
netdev_unlock(port->napi.dev);
return 0;
}
netif_tx_stop_all_queues(pp->dev);
Expand Down

0 comments on commit 59e00e8

Please sign in to comment.