Skip to content

Commit

Permalink
iio: accel: bmc150: Document duplicate ACPI entries with bmi323 driver
Browse files Browse the repository at this point in the history
Adds a description of the duplicate ACPI identifier issue
between devices using bmc150 and bmi323.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Co-developed-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Co-developed-by: Denis Benato <benato.denis96@gmail.com>
Signed-off-by: Denis Benato <benato.denis96@gmail.com>
Co-developed-by: Antheas Kapenekakis <lkml@antheas.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
Signed-off-by: Jonathan LoBue <jlobue10@gmail.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240216182253.27069-1-jlobue10@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Jonathan LoBue authored and Jonathan Cameron committed Feb 19, 2024
1 parent 00ef770 commit 5a01e81
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions drivers/iio/accel/bmc150-accel-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,19 @@ static const struct acpi_device_id bmc150_accel_acpi_match[] = {
{"BMA250E"},
{"BMC150A"},
{"BMI055A"},
/*
* The "BOSC0200" identifier used here is not unique to devices using
* bmc150. The same "BOSC0200" identifier is found in the ACPI tables
* of the ASUS ROG ALLY and Ayaneo AIR Plus which both use a Bosch
* BMI323 chip. This creates a conflict with duplicate ACPI identifiers
* which multiple drivers want to use. Fortunately, when the bmc150
* driver starts to load on the ASUS ROG ALLY, the chip ID check
* portion fails (correctly) because the chip IDs received (via i2c)
* are unique between bmc150 and bmi323 and a dmesg output similar to
* this: "bmc150_accel_i2c i2c-BOSC0200:00: Invalid chip 0" can be
* seen. This allows the bmi323 driver to take over for ASUS ROG ALLY,
* and other devices using the bmi323 chip.
*/
{"BOSC0200"},
{"BSBA0150"},
{"DUAL250E"},
Expand Down

0 comments on commit 5a01e81

Please sign in to comment.