Skip to content

Commit

Permalink
wireguard: peer: put frequently used members above cache lines
Browse files Browse the repository at this point in the history
The is_dead boolean is checked for every single packet, while the
internal_id member is used basically only for pr_debug messages. So it
makes sense to hoist up is_dead into some space formerly unused by a
struct hole, while demoting internal_api to below the lowest struct
cache line.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Jason A. Donenfeld authored and Jakub Kicinski committed Feb 23, 2021
1 parent d5a49aa commit 5a05986
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/wireguard/peer.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ struct wg_peer {
struct crypt_queue tx_queue, rx_queue;
struct sk_buff_head staged_packet_queue;
int serial_work_cpu;
bool is_dead;
struct noise_keypairs keypairs;
struct endpoint endpoint;
struct dst_cache endpoint_cache;
Expand All @@ -61,9 +62,8 @@ struct wg_peer {
struct rcu_head rcu;
struct list_head peer_list;
struct list_head allowedips_list;
u64 internal_id;
struct napi_struct napi;
bool is_dead;
u64 internal_id;
};

struct wg_peer *wg_peer_create(struct wg_device *wg,
Expand Down

0 comments on commit 5a05986

Please sign in to comment.