Skip to content

Commit

Permalink
nl80211/cfg80211: add max_sched_scan_ie_len in the hw description
Browse files Browse the repository at this point in the history
Some chips may support different lengths of user-supplied IEs with a
single scheduled scan command than with a single normal scan command.

To support this, this patch creates a separate hardware description
element that describes the maximum size of user-supplied information
element data supported in scheduled scans.

Signed-off-by: Luciano Coelho <coelho@ti.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Luciano Coelho authored and John W. Linville committed Jul 15, 2011
1 parent 93b6aa6 commit 5a865ba
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
3 changes: 3 additions & 0 deletions include/linux/nl80211.h
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,8 @@ enum nl80211_commands {
* scan with a single scheduled scan request, a wiphy attribute.
* @NL80211_ATTR_MAX_SCAN_IE_LEN: maximum length of information elements
* that can be added to a scan request
* @NL80211_ATTR_MAX_SCHED_SCAN_IE_LEN: maximum length of information
* elements that can be added to a scheduled scan request
*
* @NL80211_ATTR_SCAN_FREQUENCIES: nested attribute with frequencies (in MHz)
* @NL80211_ATTR_SCAN_SSIDS: nested attribute with SSIDs, leave out for passive
Expand Down Expand Up @@ -1213,6 +1215,7 @@ enum nl80211_attrs {
NL80211_ATTR_REKEY_DATA,

NL80211_ATTR_MAX_NUM_SCHED_SCAN_SSIDS,
NL80211_ATTR_MAX_SCHED_SCAN_IE_LEN,

/* add attributes here, update the policy in nl80211.c */

Expand Down
3 changes: 3 additions & 0 deletions include/net/cfg80211.h
Original file line number Diff line number Diff line change
Expand Up @@ -1763,6 +1763,8 @@ struct wiphy_wowlan_support {
* @max_scan_ie_len: maximum length of user-controlled IEs device can
* add to probe request frames transmitted during a scan, must not
* include fixed IEs like supported rates
* @max_sched_scan_ie_len: same as max_scan_ie_len, but for scheduled
* scans
* @coverage_class: current coverage class
* @fw_version: firmware version for ethtool reporting
* @hw_version: hardware version for ethtool reporting
Expand Down Expand Up @@ -1816,6 +1818,7 @@ struct wiphy {
u8 max_scan_ssids;
u8 max_sched_scan_ssids;
u16 max_scan_ie_len;
u16 max_sched_scan_ie_len;

int n_cipher_suites;
const u32 *cipher_suites;
Expand Down
4 changes: 3 additions & 1 deletion net/wireless/nl80211.c
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,8 @@ static int nl80211_send_wiphy(struct sk_buff *msg, u32 pid, u32 seq, int flags,
dev->wiphy.max_sched_scan_ssids);
NLA_PUT_U16(msg, NL80211_ATTR_MAX_SCAN_IE_LEN,
dev->wiphy.max_scan_ie_len);
NLA_PUT_U16(msg, NL80211_ATTR_MAX_SCHED_SCAN_IE_LEN,
dev->wiphy.max_sched_scan_ie_len);

if (dev->wiphy.flags & WIPHY_FLAG_IBSS_RSN)
NLA_PUT_FLAG(msg, NL80211_ATTR_SUPPORT_IBSS_RSN);
Expand Down Expand Up @@ -3521,7 +3523,7 @@ static int nl80211_start_sched_scan(struct sk_buff *skb,
else
ie_len = 0;

if (ie_len > wiphy->max_scan_ie_len)
if (ie_len > wiphy->max_sched_scan_ie_len)
return -EINVAL;

mutex_lock(&rdev->sched_scan_mtx);
Expand Down

0 comments on commit 5a865ba

Please sign in to comment.