Skip to content

Commit

Permalink
pinctrl: baytrail: reduce scope of spinlock in ->dbg_show() hook
Browse files Browse the repository at this point in the history
Reduce scope of spinlock to IO operations in ->dbg_show() hook
and save a few bytes.

add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-12 (-12)
Function                                     old     new   delta
byt_gpio_dbg_show                            890     878     -12
Total: Before=17029, After=17017, chg -0.07%

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20230616203356.27343-2-raag.jadav@intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  • Loading branch information
Raag Jadav authored and Andy Shevchenko committed Jun 19, 2023
1 parent d1bfdf8 commit 5a9fa4c
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions drivers/pinctrl/intel/pinctrl-baytrail.c
Original file line number Diff line number Diff line change
Expand Up @@ -1241,30 +1241,30 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)

for (i = 0; i < vg->soc->npins; i++) {
const struct intel_community *comm;
void __iomem *conf_reg, *val_reg;
const char *pull_str = NULL;
const char *pull = NULL;
void __iomem *reg;
unsigned long flags;
const char *label;
unsigned int pin;

raw_spin_lock_irqsave(&byt_lock, flags);
pin = vg->soc->pins[i].number;
reg = byt_gpio_reg(vg, pin, BYT_CONF0_REG);
if (!reg) {

conf_reg = byt_gpio_reg(vg, pin, BYT_CONF0_REG);
if (!conf_reg) {
seq_printf(s, "Pin %i: can't retrieve CONF0\n", pin);
raw_spin_unlock_irqrestore(&byt_lock, flags);
continue;
}
conf0 = readl(reg);

reg = byt_gpio_reg(vg, pin, BYT_VAL_REG);
if (!reg) {
val_reg = byt_gpio_reg(vg, pin, BYT_VAL_REG);
if (!val_reg) {
seq_printf(s, "Pin %i: can't retrieve VAL\n", pin);
raw_spin_unlock_irqrestore(&byt_lock, flags);
continue;
}
val = readl(reg);

raw_spin_lock_irqsave(&byt_lock, flags);
conf0 = readl(conf_reg);
val = readl(val_reg);
raw_spin_unlock_irqrestore(&byt_lock, flags);

comm = byt_get_community(vg, pin);
Expand Down

0 comments on commit 5a9fa4c

Please sign in to comment.