Skip to content

Commit

Permalink
x86: uninline __pte_free_tlb() and __pmd_free_tlb()
Browse files Browse the repository at this point in the history
this also removes an include file dependency.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Jan 31, 2008
1 parent 072b7a5 commit 5aa0508
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 17 deletions.
23 changes: 23 additions & 0 deletions arch/x86/mm/pgtable_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -376,3 +376,26 @@ void check_pgt_cache(void)
{
quicklist_trim(0, pgd_dtor, 25, 16);
}

void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte)
{
paravirt_release_pt(page_to_pfn(pte));
tlb_remove_page(tlb, pte);
}

#ifdef CONFIG_X86_PAE

void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd)
{
/* This is called just after the pmd has been detached from
the pgd, which requires a full tlb flush to be recognized
by the CPU. Rather than incurring multiple tlb flushes
while the address space is being pulled down, make the tlb
gathering machinery do a full flush when we're done. */
tlb->fullmm = 1;

paravirt_release_pd(__pa(pmd) >> PAGE_SHIFT);
tlb_remove_page(tlb, virt_to_page(pmd));
}

#endif
20 changes: 3 additions & 17 deletions include/asm-x86/pgalloc_32.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#include <linux/threads.h>
#include <linux/mm.h> /* for struct page */
#include <linux/pagemap.h>
#include <asm/tlb.h>
#include <asm-generic/tlb.h>

Expand Down Expand Up @@ -51,11 +52,7 @@ static inline void pte_free(struct page *pte)
}


static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte)
{
paravirt_release_pt(page_to_pfn(pte));
tlb_remove_page(tlb, pte);
}
extern void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte);

#ifdef CONFIG_X86_PAE
/*
Expand All @@ -72,18 +69,7 @@ static inline void pmd_free(pmd_t *pmd)
free_page((unsigned long)pmd);
}

static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd)
{
/* This is called just after the pmd has been detached from
the pgd, which requires a full tlb flush to be recognized
by the CPU. Rather than incurring multiple tlb flushes
while the address space is being pulled down, make the tlb
gathering machinery do a full flush when we're done. */
tlb->fullmm = 1;

paravirt_release_pd(__pa(pmd) >> PAGE_SHIFT);
tlb_remove_page(tlb, virt_to_page(pmd));
}
extern void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd);

static inline void pud_populate(struct mm_struct *mm, pud_t *pudp, pmd_t *pmd)
{
Expand Down

0 comments on commit 5aa0508

Please sign in to comment.