Skip to content

Commit

Permalink
netfilter: nf_nat_sip: fix mangling
Browse files Browse the repository at this point in the history
In (b20ab9c netfilter: nf_ct_helper: better logging for dropped packets)
there were some missing brackets around the logging information, thus
always returning drop.

Closes https://bugzilla.kernel.org/show_bug.cgi?id=60061

Signed-off-by: Balazs Peter Odor <balazs@obiserver.hu>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
Balazs Peter Odor authored and Pablo Neira Ayuso committed Jun 24, 2013
1 parent 142dcdd commit 5aed938
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/netfilter/nf_nat_sip.c
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,10 @@ static unsigned int nf_nat_sip(struct sk_buff *skb, unsigned int protoff,
&ct->tuplehash[!dir].tuple.src.u3,
false);
if (!mangle_packet(skb, protoff, dataoff, dptr, datalen,
poff, plen, buffer, buflen))
poff, plen, buffer, buflen)) {
nf_ct_helper_log(skb, ct, "cannot mangle received");
return NF_DROP;
}
}

/* The rport= parameter (RFC 3581) contains the port number
Expand Down

0 comments on commit 5aed938

Please sign in to comment.