Skip to content

Commit

Permalink
dt-bindings: watchdog: sunxi: clarify clock support
Browse files Browse the repository at this point in the history
Most Allwinner SoCs have just one input clock to drive the watchdog
peripheral. So far this is the 24 MHz "HOSC" oscillator, divided down
internally to 32 KHz.
The F1C100 series watchdog however uses the unchanged 32 KHz "LOSC" as
its only clock input, which has the same effect, but let's the binding
description mismatch.

Change the binding description to name the clocks more loosely, so both
the LOSC and divided HOSC match the description. As the fixed clock names
now make less sense, drop them from SoCs supporting just one clock
input, they were not used by any DT anyway.

For the newer SoCs, supporting a choice of two input clocks, we keep
both the description and clock-names requirement.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220317162349.739636-3-andre.przywara@arm.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
  • Loading branch information
Andre Przywara authored and Wim Van Sebroeck committed May 8, 2022
1 parent 70fabe2 commit 5b38db0
Showing 1 changed file with 8 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,8 @@ properties:
clocks:
minItems: 1
items:
- description: High-frequency oscillator input, divided internally
- description: Low-frequency oscillator input, only found on some variants

clock-names:
minItems: 1
items:
- const: hosc
- const: losc
- description: 32 KHz input clock
- description: secondary clock source

interrupts:
maxItems: 1
Expand All @@ -71,9 +65,14 @@ then:
properties:
clocks:
minItems: 2
items:
- description: High-frequency oscillator input, divided internally
- description: Low-frequency oscillator input

clock-names:
minItems: 2
items:
- const: hosc
- const: losc

required:
- clock-names
Expand All @@ -83,9 +82,6 @@ else:
clocks:
maxItems: 1

clock-names:
maxItems: 1

unevaluatedProperties: false

examples:
Expand Down

0 comments on commit 5b38db0

Please sign in to comment.