Skip to content

Commit

Permalink
pcmcia: synclink_cs: fix information leak to userland
Browse files Browse the repository at this point in the history
Structure new_line is copied to userland with some padding fields unitialized.
It leads to leaking of stack memory.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
CC: stable@kernel.org
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
  • Loading branch information
Vasiliy Kulikov authored and Dominik Brodowski committed Oct 21, 2010
1 parent 97299c7 commit 5b917a1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/char/pcmcia/synclink_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -4097,6 +4097,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
if (cmd != SIOCWANDEV)
return hdlc_ioctl(dev, ifr, cmd);

memset(&new_line, 0, size);

switch(ifr->ifr_settings.type) {
case IF_GET_IFACE: /* return current sync_serial_settings */

Expand Down

0 comments on commit 5b917a1

Please sign in to comment.