Skip to content

Commit

Permalink
net: remove redundant config PCI dependency for some network driver c…
Browse files Browse the repository at this point in the history
…onfigs

While reviewing dependencies in some Kconfig files, I noticed the redundant
dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always,
since its introduction, been dependent on the config PCI. So, it is
sufficient to just depend on PCI_MSI, and know that the dependency on PCI
is implicitly implied.

Reduce the dependencies of some network driver configs.
No functional change and effective change of Kconfig dependendencies.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Dimitris Michailidis <dmichail@fungible.com>
Link: https://lore.kernel.org/r/20230111125855.19020-1-lukas.bulwahn@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Lukas Bulwahn authored and Jakub Kicinski committed Jan 13, 2023
1 parent a1cf597 commit 5bee990
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/freescale/enetc/Kconfig
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
config FSL_ENETC
tristate "ENETC PF driver"
depends on PCI && PCI_MSI
depends on PCI_MSI
select FSL_ENETC_IERB
select FSL_ENETC_MDIO
select PHYLINK
Expand All @@ -16,7 +16,7 @@ config FSL_ENETC

config FSL_ENETC_VF
tristate "ENETC VF driver"
depends on PCI && PCI_MSI
depends on PCI_MSI
select FSL_ENETC_MDIO
select PHYLINK
select DIMLIB
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ethernet/fungible/funeth/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

config FUN_ETH
tristate "Fungible Ethernet device driver"
depends on PCI && PCI_MSI
depends on PCI_MSI
depends on TLS && TLS_DEVICE || TLS_DEVICE=n
select NET_DEVLINK
select FUN_CORE
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ethernet/netronome/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if NET_VENDOR_NETRONOME

config NFP
tristate "Netronome(R) NFP4000/NFP6000 NIC driver"
depends on PCI && PCI_MSI
depends on PCI_MSI
depends on VXLAN || VXLAN=n
depends on TLS && TLS_DEVICE || TLS_DEVICE=n
select NET_DEVLINK
Expand Down

0 comments on commit 5bee990

Please sign in to comment.