Skip to content

Commit

Permalink
TI Davinci EMAC : Fix Console Hang when bringing the interface down
Browse files Browse the repository at this point in the history
In the NAPI poll function(emac_poll), check for netif_running()
is unnecassary. In addition to associated runtime overhead, it
also results in a continuous softirq loop when the interface is
brought down under heavy traffic(tested wit Traffic Generator).
Once the interface is disabled, the poll function always returns
zero(with the check for netif_running) and napi_complete() would
never get called resulting in softirq loop.

Signed-off-by: Sriramakrishnan <srk@ti.com>
Acked-by: Chaithrika U S <chaithrika@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sriram authored and David S. Miller committed Nov 16, 2009
1 parent f88c5b9 commit 5bfa2a1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/davinci_emac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2140,9 +2140,6 @@ static int emac_poll(struct napi_struct *napi, int budget)
u32 status = 0;
u32 num_pkts = 0;

if (!netif_running(ndev))
return 0;

/* Check interrupt vectors and call packet processing */
status = emac_read(EMAC_MACINVECTOR);

Expand Down

0 comments on commit 5bfa2a1

Please sign in to comment.