Skip to content

Commit

Permalink
ASoC: soc-card: add snd_soc_card_late_probe()
Browse files Browse the repository at this point in the history
Card related function should be implemented at soc-card now.
This patch adds it.

card has "card->probe" and "card->late_probe" callbacks,
and "late_probe" callback is called after "probe".
This means, we can set "card->probed" flag afer "late_probe"
for all cases.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/87v9kgzv4w.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Kuninori Morimoto authored and Mark Brown committed May 30, 2020
1 parent 73de4b0 commit 5c0eac0
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 9 deletions.
1 change: 1 addition & 0 deletions include/sound/soc-card.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ int snd_soc_card_resume_pre(struct snd_soc_card *card);
int snd_soc_card_resume_post(struct snd_soc_card *card);

int snd_soc_card_probe(struct snd_soc_card *card);
int snd_soc_card_late_probe(struct snd_soc_card *card);

/* device driver data */
static inline void snd_soc_card_set_drvdata(struct snd_soc_card *card,
Expand Down
24 changes: 24 additions & 0 deletions sound/soc/soc-card.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,27 @@ int snd_soc_card_probe(struct snd_soc_card *card)

return 0;
}

int snd_soc_card_late_probe(struct snd_soc_card *card)
{
if (card->late_probe) {
int ret = card->late_probe(card);

if (ret < 0)
return soc_card_ret(card, ret);
}

/*
* It has "card->probe" and "card->late_probe" callbacks,
* and "late_probe" callback is called after "probe".
* This means, we can set "card->probed" flag afer "late_probe"
* for all cases.
*
* see
* snd_soc_bind_card()
* snd_soc_card_probe()
*/
card->probed = 1;

return 0;
}
12 changes: 3 additions & 9 deletions sound/soc/soc-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1910,15 +1910,9 @@ static int snd_soc_bind_card(struct snd_soc_card *card)
}
}

if (card->late_probe) {
ret = card->late_probe(card);
if (ret < 0) {
dev_err(card->dev, "ASoC: %s late_probe() failed: %d\n",
card->name, ret);
goto probe_end;
}
}
card->probed = 1;
ret = snd_soc_card_late_probe(card);
if (ret < 0)
goto probe_end;

snd_soc_dapm_new_widgets(card);

Expand Down

0 comments on commit 5c0eac0

Please sign in to comment.