Skip to content

Commit

Permalink
switchdev: add new switchdev_port_bridge_dellink
Browse files Browse the repository at this point in the history
Same change as setlink.  Provide the wrapper op for SELF ndo_bridge_dellink
and call into the switchdev driver to delete afspec VLANs.

Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Scott Feldman authored and David S. Miller committed May 12, 2015
1 parent 41c498b commit 5c34e02
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 12 deletions.
6 changes: 6 additions & 0 deletions include/net/switchdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,12 @@ static inline int switchdev_port_obj_del(struct net_device *dev,
return -EOPNOTSUPP;
}

static inline int switchdev_port_bridge_dellink(struct net_device *dev,
struct nlmsghdr *nlh, u16 flags)
{
return -EOPNOTSUPP;
}

static inline int register_switchdev_notifier(struct notifier_block *nb)
{
return 0;
Expand Down
24 changes: 12 additions & 12 deletions net/switchdev/switchdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -512,27 +512,27 @@ int switchdev_port_bridge_setlink(struct net_device *dev,
EXPORT_SYMBOL_GPL(switchdev_port_bridge_setlink);

/**
* switchdev_port_bridge_dellink - Notify switch device port of bridge
* port attribute delete
* switchdev_port_bridge_dellink - Set bridge port attributes
*
* @dev: port device
* @nlh: netlink msg with bridge port attributes
* @flags: bridge setlink flags
* @nlh: netlink header
* @flags: netlink flags
*
* Notify switch device port of bridge port attribute delete
* Called for SELF on rtnl_bridge_dellink to set bridge port
* attributes.
*/
int switchdev_port_bridge_dellink(struct net_device *dev,
struct nlmsghdr *nlh, u16 flags)
{
const struct net_device_ops *ops = dev->netdev_ops;

if (!(dev->features & NETIF_F_HW_SWITCH_OFFLOAD))
return 0;
struct nlattr *afspec;

if (!ops->ndo_bridge_dellink)
return -EOPNOTSUPP;
afspec = nlmsg_find_attr(nlh, sizeof(struct ifinfomsg),
IFLA_AF_SPEC);
if (afspec)
return switchdev_port_br_afspec(dev, afspec,
switchdev_port_obj_del);

return ops->ndo_bridge_dellink(dev, nlh, flags);
return 0;
}
EXPORT_SYMBOL_GPL(switchdev_port_bridge_dellink);

Expand Down

0 comments on commit 5c34e02

Please sign in to comment.