Skip to content

Commit

Permalink
video: bfin_adv7393fb: Convert to kstrtouint_from_user
Browse files Browse the repository at this point in the history
This patch removes a call to the deprecated simple_strtoul function
and simplifies the code by replacing two function calls with one
call to kstrtouint_from_user.

-Simplify the adv7393_write_proc function by replacing the
 simple_strtoul and copy_from_user calls with one call
 to kstrtouint_from_user.

-Change the count parameter from unsigned long to size_t as
 this is the type that the kstrtouint_from_user function expects.
 (size_t is what will be passed to the adv7393_write_proc function
 by the proc write handler function proc_file_write anyway)

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
  • Loading branch information
Emil Goode authored and Florian Tobias Schandinat committed Jun 5, 2012
1 parent 70b6eae commit 5c888aa
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/video/bfin_adv7393fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -353,18 +353,16 @@ adv7393_read_proc(char *page, char **start, off_t off,

static int
adv7393_write_proc(struct file *file, const char __user * buffer,
unsigned long count, void *data)
size_t count, void *data)
{
struct adv7393fb_device *fbdev = data;
char line[8];
unsigned int val;
int ret;

ret = copy_from_user(line, buffer, count);
ret = kstrtouint_from_user(buffer, count, 0, &val);
if (ret)
return -EFAULT;

val = simple_strtoul(line, NULL, 0);
adv7393_write(fbdev->client, val >> 8, val & 0xff);

return count;
Expand Down

0 comments on commit 5c888aa

Please sign in to comment.