Skip to content

Commit

Permalink
bnx2x: drop redundant error message about allocation failure
Browse files Browse the repository at this point in the history
alloc_pages() already prints a warning when it fails. No need to emit
another message. Certainly not at KERN_ERR level, because it is no big
deal if this GFP_ATOMIC allocation fails occasionally.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Michal Schmidt authored and David S. Miller committed Dec 6, 2015
1 parent b618aaa commit 5c9ffde
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
Original file line number Diff line number Diff line change
Expand Up @@ -558,10 +558,8 @@ static int bnx2x_alloc_rx_sge(struct bnx2x *bp, struct bnx2x_fastpath *fp,
put_page(pool->page);

pool->page = alloc_pages(gfp_mask, PAGES_PER_SGE_SHIFT);
if (unlikely(!pool->page)) {
BNX2X_ERR("Can't alloc sge\n");
if (unlikely(!pool->page))
return -ENOMEM;
}

pool->offset = 0;
}
Expand Down

0 comments on commit 5c9ffde

Please sign in to comment.