Skip to content

Commit

Permalink
block: move rq_qos_exit() into disk_release()
Browse files Browse the repository at this point in the history
Keep all teardown of file system I/O related functionality in one place.
There can't be file system I/O in disk_release(), so it is safe to move
rq_qos_exit() there.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220308055200.735835-15-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Ming Lei authored and Jens Axboe committed Mar 9, 2022
1 parent 2888307 commit 5ca7546
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions block/genhd.c
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,6 @@ void del_gendisk(struct gendisk *disk)

blk_mq_freeze_queue_wait(q);

rq_qos_exit(q);
blk_sync_queue(q);
blk_flush_integrity();
/*
Expand Down Expand Up @@ -1119,7 +1118,7 @@ static void disk_release_mq(struct request_queue *q)
elevator_exit(q);
mutex_unlock(&q->sysfs_lock);
}

rq_qos_exit(q);
__blk_mq_unfreeze_queue(q, true);
}

Expand Down

0 comments on commit 5ca7546

Please sign in to comment.