Skip to content

Commit

Permalink
reiserfs: fix __RASSERT format string
Browse files Browse the repository at this point in the history
__RASSERT format string does not use the PID argument.  reiserfs_panic
arguments are therefore formatted with the wrong format specifier (for
example __LINE__ with %s).  This bug was introduced when commit
c3a9c21 ("reiserfs: rework reiserfs_panic") removed a
"reiserfs[%i]" prefix.

This bug is only triggered when using CONFIG_REISERFS_CHECK, otherwise
__RASSERT is never used.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Acked-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Nicolas Iooss authored and Jan Kara committed Mar 17, 2015
1 parent 7dca054 commit 5ce1aca
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/reiserfs/reiserfs.h
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,6 @@ do { \
if (!(cond)) \
reiserfs_panic(NULL, "assertion failure", "(" #cond ") at " \
__FILE__ ":%i:%s: " format "\n", \
in_interrupt() ? -1 : task_pid_nr(current), \
__LINE__, __func__ , ##args); \
} while (0)

Expand Down

0 comments on commit 5ce1aca

Please sign in to comment.