Skip to content

Commit

Permalink
drm_dp_cec: check that aux has a transfer function
Browse files Browse the repository at this point in the history
If aux->transfer == NULL, then just return without doing
anything. In that case the function is likely called for
a non-(e)DP connector.

This never happened for the i915 driver, but the nouveau and amdgpu
drivers need this check.

The alternative would be to add this check in those drivers before
every drm_dp_cec call, but it makes sense to check it in the
drm_dp_cec functions to prevent a kernel oops.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180827075820.41109-2-hverkuil@xs4all.nl
  • Loading branch information
Hans Verkuil committed Aug 31, 2018
1 parent 09c4b49 commit 5ce70c7
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions drivers/gpu/drm/drm_dp_cec.c
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,10 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux)
u8 cec_irq;
int ret;

/* No transfer function was set, so not a DP connector */
if (!aux->transfer)
return;

mutex_lock(&aux->cec.lock);
if (!aux->cec.adap)
goto unlock;
Expand Down Expand Up @@ -293,6 +297,10 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid)
unsigned int num_las = 1;
u8 cap;

/* No transfer function was set, so not a DP connector */
if (!aux->transfer)
return;

#ifndef CONFIG_MEDIA_CEC_RC
/*
* CEC_CAP_RC is part of CEC_CAP_DEFAULTS, but it is stripped by
Expand Down Expand Up @@ -361,6 +369,10 @@ EXPORT_SYMBOL(drm_dp_cec_set_edid);
*/
void drm_dp_cec_unset_edid(struct drm_dp_aux *aux)
{
/* No transfer function was set, so not a DP connector */
if (!aux->transfer)
return;

cancel_delayed_work_sync(&aux->cec.unregister_work);

mutex_lock(&aux->cec.lock);
Expand Down Expand Up @@ -404,6 +416,8 @@ void drm_dp_cec_register_connector(struct drm_dp_aux *aux, const char *name,
struct device *parent)
{
WARN_ON(aux->cec.adap);
if (WARN_ON(!aux->transfer))
return;
aux->cec.name = name;
aux->cec.parent = parent;
INIT_DELAYED_WORK(&aux->cec.unregister_work,
Expand Down

0 comments on commit 5ce70c7

Please sign in to comment.