Skip to content

Commit

Permalink
drm/i915: Add debug message for FB plane[0].offset!=0 error
Browse files Browse the repository at this point in the history
Print a debug message if the FB plane[0] offset is not 0 as expected, to
help understainding an add FB IOCTL fail.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191231233756.18753-4-imre.deak@intel.com
  • Loading branch information
Imre Deak committed Jan 7, 2020
1 parent d156135 commit 5cf15df
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/gpu/drm/i915/display/intel_display.c
Original file line number Diff line number Diff line change
@@ -16912,8 +16912,11 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
}

/* FIXME need to adjust LINOFF/TILEOFF accordingly. */
if (mode_cmd->offsets[0] != 0)
if (mode_cmd->offsets[0] != 0) {
DRM_DEBUG_KMS("plane 0 offset (0x%08x) must be 0\n",
mode_cmd->offsets[0]);
goto err;
}

drm_helper_mode_fill_fb_struct(&dev_priv->drm, fb, mode_cmd);

0 comments on commit 5cf15df

Please sign in to comment.