Skip to content

Commit

Permalink
udf: Convert udf_adinicb_writepage() to memcpy_to_page()
Browse files Browse the repository at this point in the history
Instead of mapping the page manually with kmap() atomic, use helper
memcpy_to_page(). Also delete the pointless SetPageUptodate() call.

Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Jan Kara committed Jan 26, 2023
1 parent 7b7f686 commit 5cfc453
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions fs/udf/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,11 @@ static int udf_adinicb_writepage(struct page *page,
struct writeback_control *wbc, void *data)
{
struct inode *inode = page->mapping->host;
char *kaddr;
struct udf_inode_info *iinfo = UDF_I(inode);

BUG_ON(!PageLocked(page));

kaddr = kmap_atomic(page);
memcpy(iinfo->i_data + iinfo->i_lenEAttr, kaddr, i_size_read(inode));
SetPageUptodate(page);
kunmap_atomic(kaddr);
memcpy_to_page(page, 0, iinfo->i_data + iinfo->i_lenEAttr,
i_size_read(inode));
unlock_page(page);
mark_inode_dirty(inode);

Expand Down

0 comments on commit 5cfc453

Please sign in to comment.