Skip to content

Commit

Permalink
remoteproc/davinci: drop needless devm_clk_put
Browse files Browse the repository at this point in the history
The comment above disable_irq says that it is needed to ensure that the
"devm subsystem might end up releasing things before freeing the irq,
thus allowing an interrupt to sneak in while the device is being
removed." disable_irq is enough for this purpose and there is no need to
manually free the reference to the clock.

Cc: Robert Tivy <rtivy@ti.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
[moved the Cc line into the commit message]
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
  • Loading branch information
Uwe Kleine-König authored and Ohad Ben-Cohen committed Feb 24, 2014
1 parent cfbf8d4 commit 5d658bf
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/remoteproc/da8xx_remoteproc.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,6 @@ static int da8xx_rproc_remove(struct platform_device *pdev)
*/
disable_irq(drproc->irq);

devm_clk_put(dev, drproc->dsp_clk);

rproc_del(rproc);
rproc_put(rproc);

Expand Down

0 comments on commit 5d658bf

Please sign in to comment.