Skip to content

Commit

Permalink
gpio: xgs-iproc: Fix section mismatch on device tree match table
Browse files Browse the repository at this point in the history
The table of devicetree identifiers is annotated as __initconst
indicating that it can be discarded after kernel boot but it is
referenced from the driver struct which has no init annotation leading
to a linker warning:

WARNING: vmlinux.o(.data+0x82d58): Section mismatch in reference from the variable bcm_iproc_gpio_driver to the variable .init.rodata:bcm_iproc_gpio_of_match
The variable bcm_iproc_gpio_driver references
the variable __initconst bcm_iproc_gpio_of_match

Since drivers can be probed after init the lack of annotation on the
driver struct is correct so remove the annotation from the match table.

Fixes: 6a41b6c ("gpio: Add xgs-iproc driver")
Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Mark Brown authored and Linus Walleij committed Nov 7, 2019
1 parent 504369c commit 5d682fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/gpio-xgs-iproc.c
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ static int __exit iproc_gpio_remove(struct platform_device *pdev)
return 0;
}

static const struct of_device_id bcm_iproc_gpio_of_match[] __initconst = {
static const struct of_device_id bcm_iproc_gpio_of_match[] = {
{ .compatible = "brcm,iproc-gpio-cca" },
{}
};
Expand Down

0 comments on commit 5d682fa

Please sign in to comment.