Skip to content

Commit

Permalink
resources: factor out resource_clip() to simplify find_resource()
Browse files Browse the repository at this point in the history
This factors out the min/max clipping to simplify find_resource().
No functional change.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Bjorn Helgaas authored and Jesse Barnes committed Oct 26, 2010
1 parent a9cea01 commit 5d6b1fa
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions kernel/resource.c
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,15 @@ static resource_size_t simple_align_resource(void *data,
return avail->start;
}

static void resource_clip(struct resource *res, resource_size_t min,
resource_size_t max)
{
if (res->start < min)
res->start = min;
if (res->end > max)
res->end = max;
}

/*
* Find empty slot in the resource tree given range and alignment.
*/
Expand Down Expand Up @@ -394,10 +403,8 @@ static int find_resource(struct resource *root, struct resource *new,
tmp.end = this->start - 1;
else
tmp.end = root->end;
if (tmp.start < min)
tmp.start = min;
if (tmp.end > max)
tmp.end = max;

resource_clip(&tmp, min, max);
tmp.start = ALIGN(tmp.start, align);

tmp.start = alignf(alignf_data, &tmp, size, align);
Expand Down

0 comments on commit 5d6b1fa

Please sign in to comment.