Skip to content

Commit

Permalink
cpufreq: davinci: Fix clk use after free
Browse files Browse the repository at this point in the history
The remove function first frees the clks and only then calls
cpufreq_unregister_driver(). If one of the cpufreq callbacks is called
just before cpufreq_unregister_driver() is run, the freed clks might be
used.

Fixes: 6601b80 ("davinci: add generic CPUFreq driver for DaVinci")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Uwe Kleine-König authored and Rafael J. Wysocki committed Feb 9, 2023
1 parent 7cca9a9 commit 5d8f384
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/cpufreq/davinci-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,13 @@ static int __init davinci_cpufreq_probe(struct platform_device *pdev)

static int __exit davinci_cpufreq_remove(struct platform_device *pdev)
{
cpufreq_unregister_driver(&davinci_driver);

clk_put(cpufreq.armclk);

if (cpufreq.asyncclk)
clk_put(cpufreq.asyncclk);

cpufreq_unregister_driver(&davinci_driver);

return 0;
}

Expand Down

0 comments on commit 5d8f384

Please sign in to comment.