Skip to content

Commit

Permalink
drm/i915: s/plane_res_b/blocks/ etc.
Browse files Browse the repository at this point in the history
Rename a bunch of the skl+ watermark struct members to
have sensible names. Avoids me having to think what
plane_res_b/etc. means.

Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210305153610.12177-7-ville.syrjala@linux.intel.com
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
  • Loading branch information
Ville Syrjälä committed Mar 12, 2021
1 parent a5941b4 commit 5dac808
Show file tree
Hide file tree
Showing 3 changed files with 112 additions and 116 deletions.
24 changes: 12 additions & 12 deletions drivers/gpu/drm/i915/display/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -9216,12 +9216,12 @@ static void verify_wm_state(struct intel_crtc *crtc,
drm_err(&dev_priv->drm,
"[PLANE:%d:%s] mismatch in WM%d (expected e=%d b=%u l=%u, got e=%d b=%u l=%u)\n",
plane->base.base.id, plane->base.name, level,
sw_wm_level->plane_en,
sw_wm_level->plane_res_b,
sw_wm_level->plane_res_l,
hw_wm_level->plane_en,
hw_wm_level->plane_res_b,
hw_wm_level->plane_res_l);
sw_wm_level->enable,
sw_wm_level->blocks,
sw_wm_level->lines,
hw_wm_level->enable,
hw_wm_level->blocks,
hw_wm_level->lines);
}

hw_wm_level = &hw->wm.planes[plane->id].trans_wm;
Expand All @@ -9231,12 +9231,12 @@ static void verify_wm_state(struct intel_crtc *crtc,
drm_err(&dev_priv->drm,
"[PLANE:%d:%s] mismatch in trans WM (expected e=%d b=%u l=%u, got e=%d b=%u l=%u)\n",
plane->base.base.id, plane->base.name,
sw_wm_level->plane_en,
sw_wm_level->plane_res_b,
sw_wm_level->plane_res_l,
hw_wm_level->plane_en,
hw_wm_level->plane_res_b,
hw_wm_level->plane_res_l);
sw_wm_level->enable,
sw_wm_level->blocks,
sw_wm_level->lines,
hw_wm_level->enable,
hw_wm_level->blocks,
hw_wm_level->lines);
}

/* DDB */
Expand Down
6 changes: 3 additions & 3 deletions drivers/gpu/drm/i915/display/intel_display_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -725,9 +725,9 @@ struct intel_pipe_wm {

struct skl_wm_level {
u16 min_ddb_alloc;
u16 plane_res_b;
u8 plane_res_l;
bool plane_en;
u16 blocks;
u8 lines;
bool enable;
bool ignore_lines;
bool can_sagv;
};
Expand Down
Loading

0 comments on commit 5dac808

Please sign in to comment.