Skip to content

Commit

Permalink
move wm8400-regulator's probe function to .devinit.text
Browse files Browse the repository at this point in the history
A pointer to wm8400_regulator_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
  • Loading branch information
Uwe Kleine-König authored and Liam Girdwood committed Jan 17, 2009
1 parent 1de9e8e commit 5dbdf73
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/regulator/wm8400-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ static struct regulator_desc regulators[] = {
},
};

static int __init wm8400_regulator_probe(struct platform_device *pdev)
static int __devinit wm8400_regulator_probe(struct platform_device *pdev)
{
struct regulator_dev *rdev;

Expand Down

0 comments on commit 5dbdf73

Please sign in to comment.