Skip to content

Commit

Permalink
OMAPDSS: APPLY: Don't check manager settings if it is disabled
Browse files Browse the repository at this point in the history
If a manager is disabled, there is no guarantee at any point in time that all
it's parameters are configured. There is always a chance that some more
parameters are yet to be configured by a user of DSS, or by DSS itself.

However, when the manager is enabled, we can be certain that all the parameters
have been configured, as we can't enable a manager with an incomplete
configuration. Therefore, if a manager is disabled, don't check for the validity
of it's parameters or the parameters of the overlays connected to it. Only check
once it is enabled. Add a check in dss_check_settings_low() to achieve the same.

Signed-off-by: Archit Taneja <archit@ti.com>
  • Loading branch information
Archit Taneja authored and Tomi Valkeinen committed May 9, 2012
1 parent b917fa3 commit 5dd747e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/video/omap2/dss/apply.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ static int dss_check_settings_low(struct omap_overlay_manager *mgr,

mp = get_mgr_priv(mgr);

if (!mp->enabled)
return 0;

if (applying && mp->user_info_dirty)
mi = &mp->user_info;
else
Expand Down

0 comments on commit 5dd747e

Please sign in to comment.