Skip to content

Commit

Permalink
Merge tag 'mfd-fixes-4.20' of git://git.kernel.org/pub/scm/linux/kern…
Browse files Browse the repository at this point in the history
…el/git/lee/mfd

Pull mfd bugfix from Lee Jones:
 "Replace release function in cros_ec_dev"

* tag 'mfd-fixes-4.20' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd:
  Revert "mfd: cros_ec: Use devm_kzalloc for private data"
  • Loading branch information
Linus Torvalds committed Dec 5, 2018
2 parents a517af5 + 48a2ca0 commit 5e0dc1a
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/mfd/cros_ec_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,11 @@ static const struct file_operations fops = {
#endif
};

static void cros_ec_class_release(struct device *dev)
{
kfree(to_cros_ec_dev(dev));
}

static void cros_ec_sensors_register(struct cros_ec_dev *ec)
{
/*
Expand Down Expand Up @@ -395,7 +400,7 @@ static int ec_device_probe(struct platform_device *pdev)
int retval = -ENOMEM;
struct device *dev = &pdev->dev;
struct cros_ec_platform *ec_platform = dev_get_platdata(dev);
struct cros_ec_dev *ec = devm_kzalloc(dev, sizeof(*ec), GFP_KERNEL);
struct cros_ec_dev *ec = kzalloc(sizeof(*ec), GFP_KERNEL);

if (!ec)
return retval;
Expand All @@ -417,6 +422,7 @@ static int ec_device_probe(struct platform_device *pdev)
ec->class_dev.devt = MKDEV(ec_major, pdev->id);
ec->class_dev.class = &cros_class;
ec->class_dev.parent = dev;
ec->class_dev.release = cros_ec_class_release;

retval = dev_set_name(&ec->class_dev, "%s", ec_platform->ec_name);
if (retval) {
Expand Down

0 comments on commit 5e0dc1a

Please sign in to comment.