Skip to content

Commit

Permalink
sh_eth: align usage of sh_eth_modify() with rest of driver
Browse files Browse the repository at this point in the history
To be consistent with the rest of the driver when setting bits using
sh_eth_modify() the same bit should also be cleared. This have no
functional change and should have been done from the start.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Niklas Söderlund authored and David S. Miller committed Feb 1, 2017
1 parent 889711a commit 5e2ed13
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/renesas/sh_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -3271,7 +3271,7 @@ static int sh_eth_wol_setup(struct net_device *ndev)
sh_eth_write(ndev, EESIPR_ECIIP, EESIPR);

/* Enable MagicPacket */
sh_eth_modify(ndev, ECMR, 0, ECMR_MPDE);
sh_eth_modify(ndev, ECMR, ECMR_MPDE, ECMR_MPDE);

/* Increased clock usage so device won't be suspended */
clk_enable(mdp->clk);
Expand Down

0 comments on commit 5e2ed13

Please sign in to comment.