Skip to content

Commit

Permalink
ipmi: Remove incorrect use of seq_has_overflowed
Browse files Browse the repository at this point in the history
commit d6c5dc1 ("ipmi: Remove uses of return value of seq_printf")
incorrectly changed the return value of various proc_show functions
to use seq_has_overflowed().

These functions should return 0 on completion rather than 1/true
on overflow.  1 is the same as #define SEQ_SKIP which would cause
the output to not be emitted (skipped) instead.

This is a logical defect only as the length of these outputs are
all smaller than the initial allocation done by the seq filesystem.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
  • Loading branch information
Joe Perches authored and Corey Minyard committed May 5, 2015
1 parent b0e9aaa commit 5e33cd0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions drivers/char/ipmi/ipmi_msghandler.c
Original file line number Diff line number Diff line change
Expand Up @@ -2000,7 +2000,7 @@ static int smi_ipmb_proc_show(struct seq_file *m, void *v)
seq_printf(m, " %x", intf->channels[i].address);
seq_putc(m, '\n');

return seq_has_overflowed(m);
return 0;
}

static int smi_ipmb_proc_open(struct inode *inode, struct file *file)
Expand All @@ -2023,7 +2023,7 @@ static int smi_version_proc_show(struct seq_file *m, void *v)
ipmi_version_major(&intf->bmc->id),
ipmi_version_minor(&intf->bmc->id));

return seq_has_overflowed(m);
return 0;
}

static int smi_version_proc_open(struct inode *inode, struct file *file)
Expand Down
4 changes: 2 additions & 2 deletions drivers/char/ipmi/ipmi_si_intf.c
Original file line number Diff line number Diff line change
Expand Up @@ -3080,7 +3080,7 @@ static int smi_type_proc_show(struct seq_file *m, void *v)

seq_printf(m, "%s\n", si_to_str[smi->si_type]);

return seq_has_overflowed(m);
return 0;
}

static int smi_type_proc_open(struct inode *inode, struct file *file)
Expand Down Expand Up @@ -3153,7 +3153,7 @@ static int smi_params_proc_show(struct seq_file *m, void *v)
smi->irq,
smi->slave_addr);

return seq_has_overflowed(m);
return 0;
}

static int smi_params_proc_open(struct inode *inode, struct file *file)
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/ipmi/ipmi_ssif.c
Original file line number Diff line number Diff line change
Expand Up @@ -1200,7 +1200,7 @@ static int smi_type_proc_show(struct seq_file *m, void *v)
{
seq_puts(m, "ssif\n");

return seq_has_overflowed(m);
return 0;
}

static int smi_type_proc_open(struct inode *inode, struct file *file)
Expand Down

0 comments on commit 5e33cd0

Please sign in to comment.