Skip to content

Commit

Permalink
tracing: fix sparse warnings: fix (un-)signedness
Browse files Browse the repository at this point in the history
Fix these sparse warnings:

  kernel/trace/ring_buffer.c:70:37: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/ring_buffer.c:84:39: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/ring_buffer.c:96:43: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/ring_buffer.c:2475:13: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/ring_buffer.c:2475:13: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/ring_buffer.c:2478:42: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/ring_buffer.c:2478:42: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/ring_buffer.c:2500:40: warning: incorrect type in argument 3 (different signedness)
  kernel/trace/ring_buffer.c:2505:44: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/ring_buffer.c:2507:46: warning: incorrect type in argument 2 (different signedness)
  kernel/trace/trace.c:2130:40: warning: incorrect type in argument 3 (different signedness)
  kernel/trace/trace.c:2280:40: warning: incorrect type in argument 3 (different signedness)

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Hannes Eder authored and Ingo Molnar committed Feb 11, 2009
1 parent 4fd2735 commit 5e39841
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions kernel/trace/ring_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ enum {
RB_BUFFERS_DISABLED = 1 << RB_BUFFERS_DISABLED_BIT,
};

static long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
static unsigned long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;

/**
* tracing_on - enable all tracing buffers
Expand Down Expand Up @@ -2501,7 +2501,7 @@ static ssize_t
rb_simple_read(struct file *filp, char __user *ubuf,
size_t cnt, loff_t *ppos)
{
long *p = filp->private_data;
unsigned long *p = filp->private_data;
char buf[64];
int r;

Expand All @@ -2517,9 +2517,9 @@ static ssize_t
rb_simple_write(struct file *filp, const char __user *ubuf,
size_t cnt, loff_t *ppos)
{
long *p = filp->private_data;
unsigned long *p = filp->private_data;
char buf[64];
long val;
unsigned long val;
int ret;

if (cnt >= sizeof(buf))
Expand Down
6 changes: 3 additions & 3 deletions kernel/trace/trace.c
Original file line number Diff line number Diff line change
Expand Up @@ -2147,7 +2147,7 @@ tracing_ctrl_write(struct file *filp, const char __user *ubuf,
{
struct trace_array *tr = filp->private_data;
char buf[64];
long val;
unsigned long val;
int ret;

if (cnt >= sizeof(buf))
Expand Down Expand Up @@ -2295,9 +2295,9 @@ static ssize_t
tracing_max_lat_write(struct file *filp, const char __user *ubuf,
size_t cnt, loff_t *ppos)
{
long *ptr = filp->private_data;
unsigned long *ptr = filp->private_data;
char buf[64];
long val;
unsigned long val;
int ret;

if (cnt >= sizeof(buf))
Expand Down

0 comments on commit 5e39841

Please sign in to comment.