Skip to content

Commit

Permalink
ARM: dts: exynos: Fix mismatched values of SD drive strengh configura…
Browse files Browse the repository at this point in the history
…tion on exynos4415

The pinctrl drive strength register on exynos4415 is 2-bit wide for each
pin.  The pins for SD2 were configured with value of 4.  The driver does
not validate the value so this overflow effectively set a bit 1 in
adjacent pins thus configuring them to drive strength 2x.

The author's intention was probably to set drive strength of 4x.
All other SD pins are configured with drive strength of 4x.  Fix these
with same pattern.

Fixes: 9246e7f ("ARM: dts: Add dts files for exynos4415 SoC")
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Krzysztof Kozlowski committed Sep 16, 2016
1 parent f7061ff commit 5e49773
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions arch/arm/boot/dts/exynos4415-pinctrl.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -480,14 +480,14 @@
samsung,pins = "gpk2-0";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <4>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
};

sd2_cmd: sd2-cmd {
samsung,pins = "gpk2-1";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <4>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
};

sd2_cd: sd2-cd {
Expand All @@ -501,14 +501,14 @@
samsung,pins = "gpk2-3";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
samsung,pin-drv = <4>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
};

sd2_bus4: sd2-bus-width4 {
samsung,pins = "gpk2-4", "gpk2-5", "gpk2-6";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
samsung,pin-drv = <4>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
};

cam_port_b_io: cam-port-b-io {
Expand Down

0 comments on commit 5e49773

Please sign in to comment.