Skip to content

Commit

Permalink
media: pisp_be: add missing wait_prepare/finish ops
Browse files Browse the repository at this point in the history
Without these ops the v4l2-compliance blocking wait test will fail.
These ops are required to ensure that when VIDIOC_DQBUF has to
wait for buffers to arrive, the queue lock is correctly released
and retaken. Otherwise the wait for a buffer would block all other
queue ioctls.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Tested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Oct 12, 2024
1 parent 6ce4c5d commit 5e53592
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
Original file line number Diff line number Diff line change
Expand Up @@ -964,6 +964,8 @@ static const struct vb2_ops pispbe_node_queue_ops = {
.buf_queue = pispbe_node_buffer_queue,
.start_streaming = pispbe_node_start_streaming,
.stop_streaming = pispbe_node_stop_streaming,
.wait_prepare = vb2_ops_wait_prepare,
.wait_finish = vb2_ops_wait_finish,
};

static const struct v4l2_file_operations pispbe_fops = {
Expand Down

0 comments on commit 5e53592

Please sign in to comment.