Skip to content

Commit

Permalink
scsi: qla2xxx: Send Notify ACK after N2N PLOGI
Browse files Browse the repository at this point in the history
qlt_handle_login schedules session for deletion even if a login is in
progress. That causes login bouncing, i.e. a few logins are made before it
settles down.

Complete the first login by sending Notify Acknowledge IOCB via
qlt_plogi_ack_unref if the session is pending login completion.

Fixes: 9cd883f ("scsi: qla2xxx: Fix session cleanup for N2N")
Cc: Krishna Kant <krishna.kant@purestorage.com>
Cc: Alexei Potashnik <alexei@purestorage.com>
Link: https://lore.kernel.org/r/20191125165702.1013-11-r.bolshakov@yadro.com
Acked-by: Quinn Tran <qutran@marvell.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Roman Bolshakov authored and Martin K. Petersen committed Dec 9, 2019
1 parent fd1de58 commit 5e6b01d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/scsi/qla2xxx/qla_target.c
Original file line number Diff line number Diff line change
Expand Up @@ -4803,6 +4803,7 @@ static int qlt_handle_login(struct scsi_qla_host *vha,

switch (sess->disc_state) {
case DSC_DELETED:
case DSC_LOGIN_PEND:
qlt_plogi_ack_unref(vha, pla);
break;

Expand Down

0 comments on commit 5e6b01d

Please sign in to comment.