Skip to content

Commit

Permalink
MIPS: Loongson: clean up the coding style
Browse files Browse the repository at this point in the history
With the help of script/checkpatch.pl, i have cleaned up the coding
style.

1. remove un-needed header files and tune some comments.
2. remove some un-needed { }

add a new header file loongson.h:

3. move some common header files to loongson.h
4. move some common extern declartions to loongson.h

and this new header file is needed for future loongson2f support.

Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Wu Zhangjin authored and Ralf Baechle committed Sep 17, 2009
1 parent bd92aa0 commit 5e983ff
Show file tree
Hide file tree
Showing 14 changed files with 62 additions and 194 deletions.
36 changes: 36 additions & 0 deletions arch/mips/include/asm/mach-lemote/loongson.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*
* Copyright (C) 2009 Lemote, Inc. & Institute of Computing Technology
* Author: Wu Zhangjin <wuzj@lemote.com>
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*
*/

#ifndef __ASM_MACH_LOONGSON_LOONGSON_H
#define __ASM_MACH_LOONGSON_LOONGSON_H

#include <linux/io.h>
#include <linux/init.h>

/* there is an internal bonito64-compatiable northbridge in loongson2e/2f */
#include <asm/mips-boards/bonito64.h>

/* loongson internal northbridge initialization */
extern void bonito_irq_init(void);

/* loongson-based machines specific reboot setup */
extern void mips_reboot_setup(void);

/* environment arguments from bootloader */
extern unsigned long bus_clock, cpu_clock_freq;
extern unsigned long memsize, highmemsize;

/* loongson-specific command line, env and memory initialization */
extern void __init prom_init_memory(void);
extern void __init prom_init_cmdline(void);
extern void __init prom_init_env(void);

#endif /* __ASM_MACH_LOONGSON_LOONGSON_H */
8 changes: 5 additions & 3 deletions arch/mips/include/asm/mach-lemote/pci.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@
* 02139, USA.
*/

#ifndef _LEMOTE_PCI_H_
#define _LEMOTE_PCI_H_
#ifndef __ASM_MACH_LEMOTE_PCI_H_
#define __ASM_MACH_LEMOTE_PCI_H_

extern struct pci_ops bonito64_pci_ops;

#define LOONGSON2E_PCI_MEM_START 0x14000000UL
#define LOONGSON2E_PCI_MEM_END 0x1fffffffUL
#define LOONGSON2E_PCI_IO_START 0x00004000UL

#endif /* !_LEMOTE_PCI_H_ */
#endif /* !__ASM_MACH_LEMOTE_PCI_H_ */
27 changes: 2 additions & 25 deletions arch/mips/lemote/lm2e/bonito-irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,32 +10,10 @@
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
* NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 675 Mass Ave, Cambridge, MA 02139, USA.
*
*/
#include <linux/errno.h>
#include <linux/init.h>
#include <linux/io.h>
#include <linux/types.h>
#include <linux/interrupt.h>
#include <linux/irq.h>

#include <asm/mips-boards/bonito64.h>

#include <loongson.h>

static inline void bonito_irq_enable(unsigned int irq)
{
Expand Down Expand Up @@ -66,9 +44,8 @@ void bonito_irq_init(void)
{
u32 i;

for (i = BONITO_IRQ_BASE; i < BONITO_IRQ_BASE + 32; i++) {
for (i = BONITO_IRQ_BASE; i < BONITO_IRQ_BASE + 32; i++)
set_irq_chip_and_handler(i, &bonito_irq_type, handle_level_irq);
}

setup_irq(BONITO_IRQ_BASE + 10, &dma_timeout_irqaction);
}
5 changes: 2 additions & 3 deletions arch/mips/lemote/lm2e/cmdline.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*/
#include <linux/io.h>
#include <linux/init.h>

#include <asm/bootinfo.h>

#include <loongson.h>

int prom_argc;
/* pmon passes arguments in 32bit pointers */
int *_prom_argv;
Expand Down
4 changes: 1 addition & 3 deletions arch/mips/lemote/lm2e/early_printk.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,9 @@
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*/
#include <linux/io.h>
#include <linux/init.h>
#include <linux/serial_reg.h>

#include <asm/mips-boards/bonito64.h>
#include <loongson.h>

#define UART_BASE (BONITO_PCIIO_BASE + 0x3f8)

Expand Down
6 changes: 2 additions & 4 deletions arch/mips/lemote/lm2e/env.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*/

#include <linux/io.h>
#include <linux/init.h>

#include <asm/bootinfo.h>

#include <loongson.h>

unsigned long bus_clock, cpu_clock_freq;
unsigned long memsize, highmemsize;

Expand Down
6 changes: 1 addition & 5 deletions arch/mips/lemote/lm2e/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,11 @@
* option) any later version.
*/

#include <linux/init.h>
#include <linux/bootmem.h>

#include <asm/bootinfo.h>
#include <asm/mips-boards/bonito64.h>

extern void __init prom_init_cmdline(void);
extern void __init prom_init_env(void);
extern void __init prom_init_memory(void);
#include <loongson.h>

void __init prom_init(void)
{
Expand Down
48 changes: 7 additions & 41 deletions arch/mips/lemote/lm2e/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,35 +6,14 @@
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
* NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 675 Mass Ave, Cambridge, MA 02139, USA.
*
*/
#include <linux/delay.h>
#include <linux/io.h>
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/irq.h>

#include <asm/irq_cpu.h>
#include <asm/i8259.h>
#include <asm/mipsregs.h>
#include <asm/mips-boards/bonito64.h>


#include <loongson.h>
/*
* the first level int-handler will jump here if it is a bonito irq
*/
Expand Down Expand Up @@ -67,27 +46,24 @@ static void i8259_irqdispatch(void)
int irq;

irq = i8259_irq();
if (irq >= 0) {
if (irq >= 0)
do_IRQ(irq);
} else {
else
spurious_interrupt();
}

}

asmlinkage void plat_irq_dispatch(void)
{
unsigned int pending = read_c0_cause() & read_c0_status() & ST0_IM;

if (pending & CAUSEF_IP7) {
if (pending & CAUSEF_IP7)
do_IRQ(MIPS_CPU_IRQ_BASE + 7);
} else if (pending & CAUSEF_IP5) {
else if (pending & CAUSEF_IP5)
i8259_irqdispatch();
} else if (pending & CAUSEF_IP2) {
else if (pending & CAUSEF_IP2)
bonito_irqdispatch();
} else {
else
spurious_interrupt();
}
}

static struct irqaction cascade_irqaction = {
Expand All @@ -97,8 +73,6 @@ static struct irqaction cascade_irqaction = {

void __init arch_init_irq(void)
{
extern void bonito_irq_init(void);

/*
* Clear all of the interrupts while we change the able around a bit.
* int-handler is not on bootstrap
Expand Down Expand Up @@ -128,16 +102,8 @@ void __init arch_init_irq(void)
init_i8259_irqs();
bonito_irq_init();

/*
printk("GPIODATA=%x, GPIOIE=%x\n", BONITO_GPIODATA, BONITO_GPIOIE);
printk("INTEN=%x, INTSET=%x, INTCLR=%x, INTISR=%x\n",
BONITO_INTEN, BONITO_INTENSET,
BONITO_INTENCLR, BONITO_INTISR);
*/

/* bonito irq at IP2 */
setup_irq(MIPS_CPU_IRQ_BASE + 2, &cascade_irqaction);
/* 8259 irq at IP5 */
setup_irq(MIPS_CPU_IRQ_BASE + 5, &cascade_irqaction);

}
2 changes: 1 addition & 1 deletion arch/mips/lemote/lm2e/mem.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

#include <asm/bootinfo.h>

extern unsigned long memsize, highmemsize;
#include <loongson.h>

void __init prom_init_memory(void)
{
Expand Down
26 changes: 2 additions & 24 deletions arch/mips/lemote/lm2e/pci.c
Original file line number Diff line number Diff line change
@@ -1,38 +1,16 @@
/*
* pci.c
*
* Copyright (C) 2007 Lemote, Inc. & Institute of Computing Technology
* Author: Fuxin Zhang, zhangfx@lemote.com
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
* NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 675 Mass Ave, Cambridge, MA 02139, USA.
*
*/
#include <linux/types.h>
#include <linux/pci.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <asm/mips-boards/bonito64.h>
#include <asm/mach-lemote/pci.h>

extern struct pci_ops bonito64_pci_ops;
#include <pci.h>
#include <loongson.h>

static struct resource loongson2e_pci_mem_resource = {
.name = "LOONGSON2E PCI MEM",
Expand Down
43 changes: 0 additions & 43 deletions arch/mips/lemote/lm2e/reset.c

This file was deleted.

22 changes: 2 additions & 20 deletions arch/mips/lemote/lm2e/setup.c
Original file line number Diff line number Diff line change
@@ -1,36 +1,18 @@
/*
* BRIEF MODULE DESCRIPTION
* setup.c - board dependent boot routines
*
* Copyright (C) 2007 Lemote Inc. & Insititute of Computing Technology
* Author: Fuxin Zhang, zhangfx@lemote.com
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
* NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 675 Mass Ave, Cambridge, MA 02139, USA.
*
*/
#include <linux/init.h>
#include <linux/module.h>

#include <asm/wbflush.h>

#include <loongson.h>

#ifdef CONFIG_VT
#include <linux/console.h>
#include <linux/screen_info.h>
Expand Down
Loading

0 comments on commit 5e983ff

Please sign in to comment.