Skip to content

Commit

Permalink
usb: dwc3: use proper initializers for property entries
Browse files Browse the repository at this point in the history
We should not be reaching into property entries and initialize them by
hand, but rather use proper initializer macros. This way we can alter
internal representation of property entries with no visible changes to
their users.

Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Dmitry Torokhov authored and Rafael J. Wysocki committed Jan 9, 2020
1 parent eabd5e7 commit 5eb5afb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/usb/dwc3/host.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ int dwc3_host_init(struct dwc3 *dwc)
memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));

if (dwc->usb3_lpm_capable)
props[prop_idx++].name = "usb3-lpm-capable";
props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb3-lpm-capable");

if (dwc->usb2_lpm_disable)
props[prop_idx++].name = "usb2-lpm-disable";
props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb2-lpm-disable");

/**
* WORKAROUND: dwc3 revisions <=3.00a have a limitation
Expand All @@ -103,7 +103,7 @@ int dwc3_host_init(struct dwc3 *dwc)
* This following flag tells XHCI to do just that.
*/
if (dwc->revision <= DWC3_REVISION_300A)
props[prop_idx++].name = "quirk-broken-port-ped";
props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");

if (prop_idx) {
ret = platform_device_add_properties(xhci, props);
Expand Down

0 comments on commit 5eb5afb

Please sign in to comment.