Skip to content

Commit

Permalink
[SCSI] Improve SCSI_LOGGING Kconfig entry
Browse files Browse the repository at this point in the history
The Kconfig entry for SCSI_LOGGING refers the reader to
drivers/scsi/scsi.c, but I didn't find any useful information
there. There is certainly logging code in that file, but the
logging types and logging levels are described in
drivers/scsi/scsi_logging.h.

Also, the procfs file referred to in the section is incorrect.
It should be /proc/sys/dev/scsi/logging_level and not
/proc/scsi/scsi.

Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Robert Love authored and James Bottomley committed Mar 12, 2009
1 parent 0762a48 commit 5ef0741
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions drivers/scsi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -224,14 +224,15 @@ config SCSI_LOGGING
can enable logging by saying Y to "/proc file system support" and
"Sysctl support" below and executing the command

echo "scsi log token [level]" > /proc/scsi/scsi
echo <bitmask> > /proc/sys/dev/scsi/logging_level

at boot time after the /proc file system has been mounted.
where <bitmask> is a four byte value representing the logging type
and logging level for each type of logging selected.

There are a number of things that can be used for 'token' (you can
find them in the source: <file:drivers/scsi/scsi.c>), and this
allows you to select the types of information you want, and the
level allows you to select the level of verbosity.
There are a number of logging types and you can find them in the
source at <file:drivers/scsi/scsi_logging.h>. The logging levels
are also described in that file and they determine the verbosity of
the logging for each logging type.

If you say N here, it may be harder to track down some types of SCSI
problems. If you say Y here your kernel will be somewhat larger, but
Expand Down

0 comments on commit 5ef0741

Please sign in to comment.