Skip to content

Commit

Permalink
tools lib traceevent: Change tag string for error
Browse files Browse the repository at this point in the history
The traceevent lib is used by the perf tool, and when executing

  perf test -v 6

it outputs error log on the ARM64 platform:

  running test 33 '*:*'trace-cmd: No such file or directory

  [...]

  trace-cmd: Invalid argument

The trace event parsing code originally came from trace-cmd so it keeps
the tag string "trace-cmd" for errors, this easily introduces the
impression that the perf tool launches trace-cmd command for trace event
parsing, but in fact the related parsing is accomplished by the
traceevent lib.

This patch changes the tag string to "libtraceevent" so that we can
avoid confusion and let users to more easily connect the error with
traceevent lib.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20190424013802.27569-1-leo.yan@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Leo Yan authored and Arnaldo Carvalho de Melo committed May 2, 2019
1 parent 01e985e commit 5f05182
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/lib/traceevent/parse-utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
void __vwarning(const char *fmt, va_list ap)
{
if (errno)
perror("trace-cmd");
perror("libtraceevent");
errno = 0;

fprintf(stderr, " ");
Expand Down

0 comments on commit 5f05182

Please sign in to comment.