Skip to content

Commit

Permalink
gro_cells: gro_cells_receive now return error code
Browse files Browse the repository at this point in the history
so that the caller can update stats accordingly, if needed

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Paolo Abeni authored and David S. Miller committed Jul 22, 2016
1 parent 276b8c7 commit 5f652bb
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions include/net/gro_cells.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,27 +14,26 @@ struct gro_cells {
struct gro_cell __percpu *cells;
};

static inline void gro_cells_receive(struct gro_cells *gcells, struct sk_buff *skb)
static inline int gro_cells_receive(struct gro_cells *gcells, struct sk_buff *skb)
{
struct gro_cell *cell;
struct net_device *dev = skb->dev;

if (!gcells->cells || skb_cloned(skb) || !(dev->features & NETIF_F_GRO)) {
netif_rx(skb);
return;
}
if (!gcells->cells || skb_cloned(skb) || !(dev->features & NETIF_F_GRO))
return netif_rx(skb);

cell = this_cpu_ptr(gcells->cells);

if (skb_queue_len(&cell->napi_skbs) > netdev_max_backlog) {
atomic_long_inc(&dev->rx_dropped);
kfree_skb(skb);
return;
return NET_RX_DROP;
}

__skb_queue_tail(&cell->napi_skbs, skb);
if (skb_queue_len(&cell->napi_skbs) == 1)
napi_schedule(&cell->napi);
return NET_RX_SUCCESS;
}

/* called under BH context */
Expand Down

0 comments on commit 5f652bb

Please sign in to comment.