Skip to content

Commit

Permalink
usb: otg: fsl_otg: remove redundant NULL check before kfree
Browse files Browse the repository at this point in the history
kfree on NULL pointer is a no-op.

Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Syam Sidhardhan authored and Felipe Balbi committed Mar 18, 2013
1 parent 2daf596 commit 5f71791
Showing 1 changed file with 10 additions and 20 deletions.
30 changes: 10 additions & 20 deletions drivers/usb/otg/fsl_otg.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,28 +361,18 @@ int fsl_otg_init_timers(struct otg_fsm *fsm)
void fsl_otg_uninit_timers(void)
{
/* FSM used timers */
if (a_wait_vrise_tmr != NULL)
kfree(a_wait_vrise_tmr);
if (a_wait_bcon_tmr != NULL)
kfree(a_wait_bcon_tmr);
if (a_aidl_bdis_tmr != NULL)
kfree(a_aidl_bdis_tmr);
if (b_ase0_brst_tmr != NULL)
kfree(b_ase0_brst_tmr);
if (b_se0_srp_tmr != NULL)
kfree(b_se0_srp_tmr);
if (b_srp_fail_tmr != NULL)
kfree(b_srp_fail_tmr);
if (a_wait_enum_tmr != NULL)
kfree(a_wait_enum_tmr);
kfree(a_wait_vrise_tmr);
kfree(a_wait_bcon_tmr);
kfree(a_aidl_bdis_tmr);
kfree(b_ase0_brst_tmr);
kfree(b_se0_srp_tmr);
kfree(b_srp_fail_tmr);
kfree(a_wait_enum_tmr);

/* device driver used timers */
if (b_srp_wait_tmr != NULL)
kfree(b_srp_wait_tmr);
if (b_data_pulse_tmr != NULL)
kfree(b_data_pulse_tmr);
if (b_vbus_pulse_tmr != NULL)
kfree(b_vbus_pulse_tmr);
kfree(b_srp_wait_tmr);
kfree(b_data_pulse_tmr);
kfree(b_vbus_pulse_tmr);
}

/* Add timer to timer list */
Expand Down

0 comments on commit 5f71791

Please sign in to comment.