Skip to content

Commit

Permalink
staging: most: consolidate attributes for list of links
Browse files Browse the repository at this point in the history
This patch replaces three temporary variables representing the
attributes to control the links between the AIMs and HDMs with an array
of three elements to keep the corresponding code compact.

Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andrey Shvetsov authored and Greg Kroah-Hartman committed Apr 8, 2017
1 parent add98da commit 5f78862
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions drivers/staging/most/mostcore/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -854,9 +854,6 @@ static ssize_t links_show(struct most_aim_obj *aim_obj,
return offs;
}

static struct most_aim_attribute most_aim_attr_links =
__ATTR_RO(links);

/**
* split_string - parses and changes string in the buffer buf and
* splits it into two mandatory and one optional substrings.
Expand Down Expand Up @@ -1000,9 +997,6 @@ static ssize_t add_link_store(struct most_aim_obj *aim_obj,
return len;
}

static struct most_aim_attribute most_aim_attr_add_link =
__ATTR_WO(add_link);

/**
* remove_link_store - store function for remove_link attribute
* @aim_obj: pointer to AIM object
Expand Down Expand Up @@ -1043,13 +1037,16 @@ static ssize_t remove_link_store(struct most_aim_obj *aim_obj,
return len;
}

static struct most_aim_attribute most_aim_attr_remove_link =
__ATTR_WO(remove_link);
static struct most_aim_attribute most_aim_attrs[] = {
__ATTR_RO(links),
__ATTR_WO(add_link),
__ATTR_WO(remove_link),
};

static struct attribute *most_aim_def_attrs[] = {
&most_aim_attr_links.attr,
&most_aim_attr_add_link.attr,
&most_aim_attr_remove_link.attr,
&most_aim_attrs[0].attr,
&most_aim_attrs[1].attr,
&most_aim_attrs[2].attr,
NULL,
};

Expand Down

0 comments on commit 5f78862

Please sign in to comment.