Skip to content

Commit

Permalink
NFSv4: Return delegations synchronously in evict_inode
Browse files Browse the repository at this point in the history
Kinglong Mee reports that asynchronous delegations are being killed
by the call to rpc_shutdown_client() when unmounting. This can lead
to state leakage on the server until the client lease expires.

Reported-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
  • Loading branch information
Trond Myklebust committed Mar 27, 2015
1 parent 0695314 commit 5fcdfac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfs/delegation.c
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ void nfs_inode_return_delegation_noreclaim(struct inode *inode)

delegation = nfs_inode_detach_delegation(inode);
if (delegation != NULL)
nfs_do_return_delegation(inode, delegation, 0);
nfs_do_return_delegation(inode, delegation, 1);
}

/**
Expand Down

0 comments on commit 5fcdfac

Please sign in to comment.