Skip to content

Commit

Permalink
net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()
Browse files Browse the repository at this point in the history
memset() the structure ethtool_wolinfo that has padded bytes
but the padded bytes have not been zeroed out.

Signed-off-by: zhanglin <zhang.lin16@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
zhanglin authored and David S. Miller committed Oct 26, 2019
1 parent 7c3bebc commit 5ff223e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/core/ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -1396,11 +1396,13 @@ static int ethtool_reset(struct net_device *dev, char __user *useraddr)

static int ethtool_get_wol(struct net_device *dev, char __user *useraddr)
{
struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL };
struct ethtool_wolinfo wol;

if (!dev->ethtool_ops->get_wol)
return -EOPNOTSUPP;

memset(&wol, 0, sizeof(struct ethtool_wolinfo));
wol.cmd = ETHTOOL_GWOL;
dev->ethtool_ops->get_wol(dev, &wol);

if (copy_to_user(useraddr, &wol, sizeof(wol)))
Expand Down

0 comments on commit 5ff223e

Please sign in to comment.