Skip to content

Commit

Permalink
drm/i915: completely reset the value of DDI_FUNC_CTL
Browse files Browse the repository at this point in the history
Don't rely on previous values already set on the register. Everything
we're not explicitly setting should be zero for now.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Paulo Zanoni authored and Daniel Vetter committed Aug 9, 2012
1 parent dfcef25 commit 602c43d
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/gpu/drm/i915/intel_ddi.c
Original file line number Diff line number Diff line change
Expand Up @@ -723,12 +723,7 @@ void intel_ddi_mode_set(struct drm_encoder *encoder,
}

/* Enable PIPE_DDI_FUNC_CTL for the pipe to work in HDMI mode */
temp = I915_READ(DDI_FUNC_CTL(pipe));
temp &= ~PIPE_DDI_PORT_MASK;
temp &= ~PIPE_DDI_BPC_MASK;
temp &= ~PIPE_DDI_MODE_SELECT_MASK;
temp &= ~(PIPE_DDI_PVSYNC | PIPE_DDI_PHSYNC);
temp |= PIPE_DDI_FUNC_ENABLE | PIPE_DDI_SELECT_PORT(port);
temp = PIPE_DDI_FUNC_ENABLE | PIPE_DDI_SELECT_PORT(port);

switch (intel_crtc->bpp) {
case 18:
Expand Down

0 comments on commit 602c43d

Please sign in to comment.