Skip to content

Commit

Permalink
perf tools: Remove unused trace_find_next_event()
Browse files Browse the repository at this point in the history
trace_find_next_event() was buggy and pretty much a useless helper. As
there are no more users, just remove it.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org
Link: http://lore.kernel.org/lkml/20191017210636.224045576@goodmis.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Steven Rostedt (VMware) authored and Arnaldo Carvalho de Melo committed Nov 5, 2019
1 parent 443b063 commit 6047e1a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 33 deletions.
31 changes: 0 additions & 31 deletions tools/perf/util/trace-event-parse.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,37 +173,6 @@ int parse_event_file(struct tep_handle *pevent,
return tep_parse_event(pevent, buf, size, sys);
}

struct tep_event *trace_find_next_event(struct tep_handle *pevent,
struct tep_event *event)
{
static int idx;
int events_count;
struct tep_event *all_events;

all_events = tep_get_first_event(pevent);
events_count = tep_get_events_count(pevent);
if (!pevent || !all_events || events_count < 1)
return NULL;

if (!event) {
idx = 0;
return all_events;
}

if (idx < events_count && event == (all_events + idx)) {
idx++;
if (idx == events_count)
return NULL;
return (all_events + idx);
}

for (idx = 1; idx < events_count; idx++) {
if (event == (all_events + (idx - 1)))
return (all_events + idx);
}
return NULL;
}

struct flag {
const char *name;
unsigned long long value;
Expand Down
2 changes: 0 additions & 2 deletions tools/perf/util/trace-event.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ void parse_saved_cmdline(struct tep_handle *pevent, char *file, unsigned int siz

ssize_t trace_report(int fd, struct trace_event *tevent, bool repipe);

struct tep_event *trace_find_next_event(struct tep_handle *pevent,
struct tep_event *event);
unsigned long long read_size(struct tep_event *event, void *ptr, int size);
unsigned long long eval_flag(const char *flag);

Expand Down

0 comments on commit 6047e1a

Please sign in to comment.